Skip to content

[Merged by Bors] - refactor(MeasureTheory): golf Mathlib/MeasureTheory/Constructions/Pi#38353

Closed
yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
yuanyi-350:M_2
Closed

[Merged by Bors] - refactor(MeasureTheory): golf Mathlib/MeasureTheory/Constructions/Pi#38353
yuanyi-350 wants to merge 3 commits intoleanprover-community:masterfrom
yuanyi-350:M_2

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • refactors MeasureTheory/Constructions/Pi by moving pi_map_piCongrLeft next to measurePreserving_piCongrLeft and deriving it directly from .map_eq

Extracted from #38104

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

PR summary ee3a5404e5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Measure.pi_map_piCongrLeft
- pi_map_piCongrLeft

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label Apr 22, 2026
@RemyDegenne
Copy link
Copy Markdown
Contributor

You changed the name of the lemma. It was MeasureTheory.Measure.pi_map_piCongrLeft and now it's MeasureTheory.pi_map_piCongrLeft. Please restore the previous name.

@RemyDegenne RemyDegenne added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 24, 2026
@yuanyi-350 yuanyi-350 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 24, 2026
@yuanyi-350 yuanyi-350 requested a review from RemyDegenne April 24, 2026 10:22
Copy link
Copy Markdown
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 24, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
#38353)

- refactors `MeasureTheory/Constructions/Pi` by moving `pi_map_piCongrLeft` next to `measurePreserving_piCongrLeft` and deriving it directly from `.map_eq`

Extracted from #38104

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 24, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(MeasureTheory): golf Mathlib/MeasureTheory/Constructions/Pi [Merged by Bors] - refactor(MeasureTheory): golf Mathlib/MeasureTheory/Constructions/Pi Apr 24, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants